-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Algolia search parameters #75
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 95.62% 94.73% -0.90%
==========================================
Files 17 17
Lines 572 589 +17
==========================================
+ Hits 547 558 +11
- Misses 25 31 +6 ☔ View full report in Codecov by Sentry. |
00f1881
to
9b84398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add filters that are specific to our indexes. Unless we want Sam to search voiio explicitly. That might be cool if a customer sets up a bot like this.
sam/contrib/algolia/tools.py
Outdated
""" | ||
Search the platform for information that matches the given query. | ||
|
||
Translate the query into a German language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be added to the function definition in the pyproject.toml
.
sam/contrib/algolia/tools.py
Outdated
def search(query: str, _context=None) -> str: | ||
def search( | ||
query: str, | ||
start_date: str = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start_date: str = None, | |
start_date: int = None, |
yeah, there are more hard-locks on voiio that we need to fix. I'd be happy to change this, but we also need to introduce a proper plugin system. |
We'll need to unify codebases first and then I will rework this internally. |
Can't make it properly work with dates yet.