-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thrift: update (openssl3) #41967
thrift: update (openssl3) #41967
Conversation
ff8a3af
to
8aade36
Compare
actually update it |
427a380
to
b42f89e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix your commit message header to thrift: update to 0.17.0, patch for openssl3
.
There is also a sed
command in the template which should be replaced to vsed
, but I myself am not sure who ever build on ppc64* these days.
I'll do as you say, but I did not check the ppc builds. |
33490b7
to
b6ea3e9
Compare
@Vaelatern, if you may? |
d1ba2cb
to
f84da68
Compare
updated to 0.18, removed patches, now one glibc test fails:
|
working now |
@Duncaen Can this be merged? |
(also addresses #42403) |
required to build with openssl3 #37681