Update sv run script for moby to remove loop modprobe check. #41272
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
modprobe -q loop || exit 1
to enable docker to work within containers, where kernel modules may not exist/be loadable. The absence of the loop kmod does not appear to negatively impact docker running within a container.Note: to run in containers, the rest of the script doesn't work either: adding
mount -t cgroup2 cgroup2 /sys/fs/cgroup/
to/etc/rc.local
makes things work without issue. Modifying the systemd mountpoint check is too big a change to propose without extensive testing so I haven't included it as part of this PR.Testing the changes
Note: tested within a container only; I do not have access to void running on metal.
Local build testing
Linux boron 6.0.13_1 #1 SMP PREEMPT_DYNAMIC Fri Dec 16 02:05:26 UTC 2022 x86_64 GNU/Linux
(glibc)