Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sv run script for moby to remove loop modprobe check. #41272

Closed
wants to merge 1 commit into from
Closed

Update sv run script for moby to remove loop modprobe check. #41272

wants to merge 1 commit into from

Conversation

sbromberger
Copy link
Contributor

Remove modprobe -q loop || exit 1 to enable docker to work within containers, where kernel modules may not exist/be loadable. The absence of the loop kmod does not appear to negatively impact docker running within a container.

Note: to run in containers, the rest of the script doesn't work either: adding mount -t cgroup2 cgroup2 /sys/fs/cgroup/ to /etc/rc.local makes things work without issue. Modifying the systemd mountpoint check is too big a change to propose without extensive testing so I haven't included it as part of this PR.

Testing the changes

  • I tested the changes in this PR: YES*
    Note: tested within a container only; I do not have access to void running on metal.

Local build testing

  • I built this PR locally for my native architecture, Linux boron 6.0.13_1 #1 SMP PREEMPT_DYNAMIC Fri Dec 16 02:05:26 UTC 2022 x86_64 GNU/Linux (glibc)

Remove `modprobe -q loop || exit 1` to enable docker to work within containers, where kernel modules may not exist. The absence of the loop kmod does not appear to negatively impact docker running within a container.
@sbromberger sbromberger changed the title Update run Update sv run script for moby to remove loop modprobe check. Dec 24, 2022
@sbromberger
Copy link
Contributor Author

Closing pending void-linux/void-runit#101 where we'll be able to do something more intelligent here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant