-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/activate refactor #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noctera
added
kind/enhancement
New feature or request
kind/ui
UI changes
priority/medium
labels
Dec 4, 2022
luwol03
approved these changes
Jan 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add a new way to activate staged vocabs, giving the ability to activate specific groups and not all at once
Demo:
2022-12-04.13-39-44.mp4
In addition to this I have done a basic implementation of the custom learning tab, giving you the ability to start queries, apart from your daily query, that don't count into your statistics. In this tab you can select between all vocabs from a group (including unactivated) or only activated vocabs (excluding unactivated) vocabs
Demo:
2022-12-04.13-43-29.mp4
Motivation and Context
This functions will give the user more freedom in activating and learning vocabs
Checklist
Resolves
#132
#126