Add SendDataRecords to IPFIX Exporter #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a more efficient and covenient alternative to SendSet. * SendDataRecords takes a list of data Records (for the same template ID), and breaks them up into multiple IPFIX messages (with one data Set per message) as needed. * SendDataRecords can take a reusable buffer as a parameter, to avoid repeated memory allocations. We also introduce the MaxMsgSize input for the Exporter. It will be used by SendDataRecords to determine how to break up the list of Records into multiple messages. When using UDP, MaxMsgSize should be set based on the PMTU (Path MTU) to avoid fragmentation. Signed-off-by: Antonin Bas <[email protected]>
yuntanghsu
reviewed
Dec 22, 2024
antoninbas
added a commit
to antoninbas/vmware-go-ipfix
that referenced
this pull request
Jan 14, 2025
SendDataRecords was added in vmware#391 as a way to export data records more efficiently. However, this method is not convenient to use for clients which need to mutate the records after sending them (as is the case when aggregation is used). To work around this issue, we introduce a buffered exporter. The buffered exporter wraps the standard exporter process. Whenever a data record is added, it is serialized to a byte buffer immediately, and the buffer is sent when it reaches the maximum message size. Signed-off-by: Antonin Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a more efficient and covenient alternative to SendSet.
We also introduce the MaxMsgSize input for the Exporter. It will be used by SendDataRecords to determine how to break up the list of Records into multiple messages. When using UDP, MaxMsgSize should be set based on the PMTU (Path MTU) to avoid fragmentation.