Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cobra v1.8.0 #134

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

marckhouzam
Copy link
Contributor

@marckhouzam marckhouzam commented Nov 6, 2023

What this PR does / why we need it

Update to use new latest Cobra release: v1.8.0

This PR leaves to the compatibility tests use of Cobra to what it was before. There is no value in changing that version at the moment and it has delayed this PR long enough.

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

Let CI run

Release note


Additional information

Special notes for your reviewer

@marckhouzam marckhouzam added this to the v1.2.0 milestone Nov 6, 2023
vuil
vuil previously approved these changes Nov 16, 2023
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@vuil vuil dismissed their stale review November 16, 2023 17:59

revisiting questions

@marckhouzam marckhouzam modified the milestones: v1.2.0, v1.3.0 Jan 22, 2024
marckhouzam and others added 2 commits March 1, 2024 08:10
Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam marked this pull request as ready for review March 1, 2024 13:12
@marckhouzam marckhouzam requested a review from a team as a code owner March 1, 2024 13:12
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@marckhouzam marckhouzam merged commit 753b8a3 into vmware-tanzu:main Mar 6, 2024
4 checks passed
@marckhouzam marckhouzam deleted the feat/cobra1.8.0 branch March 6, 2024 00:07
vuil pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants