Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code of Conduct #844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

The repository https://github.com/vmware/.github became private today which broke our CI because we have a link to that repo. To unblock our CI, the repo was made public again, but only temporarily.
To prepare for the repo to be private again, this PR:

  • update the local CODE_OF_CONDUCT.md file to match the latest one from that repo
  • updates the link in this repo to use the local CODE_OF_CONDUCT.md

Which issue(s) this PR fixes

Fixes # N/A

Describe testing done for PR

Let CI run

Release note

Update CODE_OF_CONDUCT.md

Additional information

Special notes for your reviewer

Also, refer to the CODE_OF_CONDUCT.md of the local repository since the
previous link will be made internal in the future.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam requested a review from a team as a code owner January 14, 2025 21:49
education, socio-economic status, nationality, personal appearance, race,
religion, or sexual identity and orientation.
We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I see we removed tanzu-cli project reference in this sentence. Is it intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye. I hadn't noticed the difference.

So, the link in CONTRIBUTING.md was referring to the code of conduct from this repo: https://github.com/vmware/.github/blob/main/CODE_OF_CONDUCT.md

And we also have a local CODE_OF_CONDUCT.md file, which I guess was adapted a bit for the CLI.

What I did was replace our local one with the exact one from the global vmware repo https://github.com/vmware/.github/blob/main/CODE_OF_CONDUCT.md

We could fixup our version for Broadcom (we never did) instead of replacing it completely, but I wonder if it is worth it? Taking the global one will allow use to blindly update it if there is another change in the future.

But I'm fine with keeping ours if you prefer.
What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking the global one will allow use to blindly update it if there is another change in the future.

Sounds reasonable to me. Thanks for the clarification.

Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants