Implement singleton pattern for NewRootCmd to prevent multiple creations #840
+67
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujc25
force-pushed
the
anujc/fix-root-cmd-invocation
branch
5 times, most recently
from
6c63b90 to
07b71e5
Compare
anujc25
changed the title
Signed-off-by: Anuj Chaudhari <[email protected]>
anujc25
force-pushed
the
anujc/fix-root-cmd-invocation
branch
from
07b71e5 to
02cc270
Compare
Signed-off-by: Anuj Chaudhari <[email protected]>
Signed-off-by: Anuj Chaudhari <[email protected]>
anujc25
force-pushed
the
anujc/fix-root-cmd-invocation
branch
from
bf4217d to
901fd27
Compare
marckhouzam
approved these changes
Jan 14, 2025
prkalle
approved these changes
Jan 14, 2025
anujc25
added a commit
to anujc25/tanzu-cli
that referenced
this pull request
Jan 14, 2025
…ons (vmware-tanzu#840) * Only allow creating the NewRootCmd once with singleton pattern * Fix unit tests by using NewRootCmdForTest Signed-off-by: Anuj Chaudhari <[email protected]>
anujc25
added a commit
that referenced
this pull request
Jan 14, 2025
…ons (#840) * Only allow creating the NewRootCmd once with singleton pattern * Fix unit tests by using NewRootCmdForTest Signed-off-by: Anuj Chaudhari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #825
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer