Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default issuer to TCSP #813

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

prkalle
Copy link
Contributor

@prkalle prkalle commented Sep 16, 2024

What this PR does / why we need it

This PR updates the hardcode default issuer to TCSP. This values will only be used when reading the issuer from the centralconfig DB fails.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Removed the below 2 entries from the local centralconfig DB cache(~/.cache/tanzu/plugin_inventory/default/central_config.yaml) and tested login. I could successfully login using the TCSP issuer.

cli.core.tanzu_default_csp_metadata:
  issuerStaging: https://console-stg.tanzu.broadcom.com/csp/gateway/am/api
  issuerProduction: https://console.tanzu.broadcom.com/csp/gateway/am/api

login command is rightly using the TCSP issuer URL as shown below

❯ ./bin/tanzu login --staging --endpoint https://api.tanzu-dev.cloud.vmware.com
[i] Opening the browser window to complete the login
Log in by visiting this link:

    https://console-stg.tanzu.broadcom.com/csp/gateway/discovery?client_id=tanzu-cli-client-id&code_challenge=yeHHFyJiFsK7ensf5BvpQE5-Mp843nlbFYt5ROoCenM&code_challenge_method=S256&redirect_uri=http%3A%2F%2F127.0.0.1%3A65492%2Fcallback&response_type=code&state=308bcacfce46038b2e542f93fc3bcc33

    Optionally, paste your authorization code: [...]


[ok] Successfully logged into 'Falcons' organization and created a tanzu context

Release note


Additional information

Special notes for your reviewer

-Update the hardcode default issuer to TCSP. This values will only be used when reading the issuer from the centralconfig DB fails.

Signed-off-by: Prem Kumar Kalle <[email protected]>
@prkalle prkalle requested a review from a team as a code owner September 16, 2024 20:12
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @prkalle

@prkalle prkalle merged commit add16b3 into main Sep 16, 2024
10 checks passed
@marckhouzam marckhouzam added this to the v1.5.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants