Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the API Token generation URL in API token prompt #810

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

prkalle
Copy link
Contributor

@prkalle prkalle commented Sep 13, 2024

What this PR does / why we need it

This PR fixes the API Token generation URL in API token prompt

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Tested context creat with with both staging and production. The API token URLs(fetched from central config) are shown correctly in API token prompt.

❯ ./bin/tanzu context create
? Select context creation type Mission Control
? Enter control plane endpoint test.tmc.tanzu.com
? Give the context a name test

[i] The API key can be provided by setting the TANZU_API_TOKEN environment variable

[i] If you don't have an API token, visit the VMware Cloud Services console, select your organization, and create an API token with the TMC service roles:
  https://console.tanzu.broadcom.com/csp/gateway/portal/#/user/tokens

? API Token
[x] : interrupt
❯ ./bin/tanzu context create --staging
? Select context creation type Mission Control
? Enter control plane endpoint test.com
? Give the context a name test

[i] The API key can be provided by setting the TANZU_API_TOKEN environment variable

[i] If you don't have an API token, visit the VMware Cloud Services console, select your organization, and create an API token with the TMC service roles:
  https://console-stg.tanzu.broadcom.com/csp/gateway/portal/#/user/tokens

? API Token
[x] : interrupt

Release note


Additional information

Special notes for your reviewer

@prkalle prkalle requested a review from a team as a code owner September 13, 2024 05:46
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe we can take this opportunity to change the URL in the quickstart.md guide? There are three examples that use the old URL

@prkalle
Copy link
Contributor Author

prkalle commented Sep 13, 2024

Maybe we can take this opportunity to change the URL in the quickstart.md guide? There are three examples that use the old URL

The issuer URL is not mentioned in the docs. If you are referring to the https://api.tanzu.cloud.vmware.com URL , this is UCP endpoint URL and this has not changed yet. Thanks

Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@prkalle prkalle merged commit fd1bf73 into main Sep 13, 2024
10 checks passed
@marckhouzam marckhouzam added this to the v1.5.0 milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants