Fix context type detection logic and e2e tests for TMC context creation #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuil
force-pushed
the
vuil/test-e2e-fixes
branch
2 times, most recently
from
c00e348 to
7039b09
Compare
vuil
changed the title
Updated e2e tests to specify mission-control context type in tests involving such contexts. Also fixed context type detection logic so that forceCSP does not take precedence over explicit context type provided. Signed-off-by: Vui Lam <[email protected]>
vuil
force-pushed
the
vuil/test-e2e-fixes
branch
from
7039b09 to
cf4f650
Compare
|
The change looks good however it is not just an E2E fix right? Could you update the title to reflect that? IIUC there are now cases where the CLI can no longer automatically create a TMC context based on the endpoint alone and the user must explicitly specify the context type as TMC. Correct? |
vuil
changed the title
Thanks you are right, updated the title to match the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Describe testing done for PR
tanzu context create --type mission-control --force-cspcreates a mission-control type contextRelease note
Additional information
Special notes for your reviewer