Add support for ca cert or skip verification in login handler #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TanzuLoginHandler now leverages ca cert data or skipVerify options provided via command line flags of
tamzu login
andtanzu context create
commands, or cert information store for the issuer host. Upon successful usage of the flags, should they be provided, they will be persisted into corresponding cert information in the CLI configuration file.What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
ran unit tests
additional manual testing:
tanzu login
adtanzu context create
on host requires custom CA now fails with messageset cert config with
tanzu config cert add --host testhost --skip-cert-verify true
. Reran same commands without --insecure-skip-tls-verify and context is now successfully createdtested with valid invalid ca certs
Release note
Additional information
Special notes for your reviewer