Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id comparison when deleting nsx resource by NamespacedName #994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.36%. Comparing base (954ed89) to head (6dd07a0).

Files with missing lines Patch % Lines
...ervices/ipaddressallocation/ipaddressallocation.go 0.00% 5 Missing ⚠️
pkg/controllers/subnet/subnet_controller.go 50.00% 2 Missing and 1 partial ⚠️
...kg/controllers/subnetport/subnetport_controller.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   74.22%   74.36%   +0.13%     
==========================================
  Files         118      118              
  Lines       16378    16260     -118     
==========================================
- Hits        12157    12091      -66     
+ Misses       3451     3401      -50     
+ Partials      770      768       -2     
Flag Coverage Δ
unit-tests 74.36% <61.53%> (+0.13%) ⬆️
Files with missing lines Coverage Δ
...trollers/networkpolicy/networkpolicy_controller.go 74.82% <ø> (-0.51%) ⬇️
pkg/controllers/pod/pod_controller.go 62.08% <100.00%> (+0.50%) ⬆️
...ollers/securitypolicy/securitypolicy_controller.go 77.46% <ø> (-0.16%) ⬇️
.../controllers/staticroute/staticroute_controller.go 78.75% <100.00%> (+2.08%) ⬆️
pkg/controllers/subnetset/subnetset_controller.go 76.36% <100.00%> (+0.13%) ⬆️
pkg/nsx/services/subnet/subnet.go 70.18% <ø> (-0.09%) ⬇️
...kg/controllers/subnetport/subnetport_controller.go 75.00% <50.00%> (+0.25%) ⬆️
pkg/controllers/subnet/subnet_controller.go 71.69% <50.00%> (-0.24%) ⬇️
...ervices/ipaddressallocation/ipaddressallocation.go 52.30% <0.00%> (+5.51%) ⬆️

@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch 2 times, most recently from 1303fee to f1b4a20 Compare January 7, 2025 07:19
@yanjunz97 yanjunz97 force-pushed the improve-deletion-by-name branch from f1b4a20 to 6dd07a0 Compare January 22, 2025 03:29
@yanjunz97 yanjunz97 marked this pull request as ready for review January 22, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants