Refine NetworkInfo CR VPCState.LoadBalancerIPAddresses description #1005
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NSX LB, we don't set NSX LN SNAT IPs in NetworkInfo CR VPCState.LoadBalancerIPAddresses and leave it as empty. So, removing the description of adding NSX LB IPs not to make users confuse.
timdengyun
force-pushed
the
remove_nsxlbip_desc_in_networkinfocrd
branch
from
0deeac5 to
4e913b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
=======================================
Coverage 74.10% 74.10%
=======================================
Files 118 118
Lines 16371 16371
=======================================
Hits 12131 12131
Misses 3466 3466
Partials 774 774
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NSX LB, we don't set NSX LN SNAT IPs in NetworkInfo CR VPCState.LoadBalancerIPAddresses and leave it as empty.
So, removing the description of adding NSX LB IPs not to make users confuse.