Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the realize backoff #1002

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jan 14, 2025

Uses the same backoff for all NSX resources realized checking

Uses the same backoff for all NSX resources realized checking
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (a4c4291) to head (2097251).

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/vpc.go 0.00% 3 Missing ⚠️
pkg/nsx/services/subnet/subnet.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0    #1002      +/-   ##
==========================================
- Coverage   74.79%   74.77%   -0.02%     
==========================================
  Files         118      118              
  Lines       16381    16370      -11     
==========================================
- Hits        12252    12241      -11     
  Misses       3358     3358              
  Partials      771      771              
Flag Coverage Δ
unit-tests 74.77% <33.33%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/services/subnetport/subnetport.go 82.56% <100.00%> (-0.27%) ⬇️
pkg/nsx/services/subnet/subnet.go 65.29% <0.00%> (-0.61%) ⬇️
pkg/nsx/services/vpc/vpc.go 55.08% <0.00%> (ø)

@timdengyun
Copy link
Contributor

please add some key words, like CP or cherry-pick in the title
and also put the PR you want to pr in the tile as wel
for example:
#999

@dantingl dantingl requested a review from yanjunz97 January 15, 2025 06:06
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZou1 TaoZou1 merged commit d7767c2 into vmware-tanzu:v4.2.0 Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants