Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] Make DaemonSet name dynamic #632

Closed
wants to merge 2 commits into from
Closed

[velero] Make DaemonSet name dynamic #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb0ac73
Make DaemonSet name dynamic
Skaronator Dec 17, 2024
6ec9b57
Bump chart version
Skaronator Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/velero/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: 1.15.0
kubeVersion: ">=1.16.0-0"
description: A Helm chart for velero
name: velero
version: 8.1.0
version: 8.2.0
home: https://github.com/vmware-tanzu/velero
icon: https://cdn-images-1.medium.com/max/1600/1*-9mb3AKnKdcL_QD3CMnthQ.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/velero/templates/node-agent-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
apiVersion: apps/v1
kind: DaemonSet
metadata:
name: node-agent
name: {{ include "velero.fullname" . }}-node-agent
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#599 (comment)

@Skaronator could you please check the Velero main code resolved this issue or not yet? Appreciated 🙏

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the head up. I wasn't aware that names are hardcoded.

namespace: {{ .Release.Namespace }}
{{- with .Values.nodeAgent.annotations }}
annotations:
Expand Down
Loading