Update controller-runtime and cluster-api dependencies #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Birdrock!, thanks for opening your first Pull Request. Someone will review it soon. Thank you for committing to make Cartographer better |
|
I can resolve the conflicts, but I'd like to avoid drift as much as possible. Any chance someone could take a look at this? |
squeedee
reviewed
Oct 13, 2023
| @@ -322,6 +322,27 @@ spec: | |||
| resources: | |||
| description: Resource constraints for the application. See https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ | |||
| properties: | |||
| claims: | |||
There was a problem hiding this comment.
I don't understand why this is turning up now?. I wonder if previous commits did not remember to generate.
squeedee
reviewed
Oct 13, 2023
| @@ -342,7 +363,8 @@ spec: | |||
| description: 'Requests describes the minimum amount of compute | |||
There was a problem hiding this comment.
this is a nice improvment in codegen :D
squeedee
reviewed
Oct 13, 2023
squeedee
approved these changes
Oct 13, 2023
Birdrock
force-pushed
the
controller-runtime-dependency-update
branch
from
f3dae05 to
5c1a45d
Compare
|
Resolved go.mod and go.sum conflicts. |
- [email protected] - [email protected] Co-authored-by: Dave Walter <[email protected]>
Birdrock
force-pushed
the
controller-runtime-dependency-update
branch
from
5c1a45d to
8e0fa37
Compare
|
You'll just need to resolve the lint and regen issues: |
Co-authored-by: Dave Walter <[email protected]>
|
I've made the updates requested. Please let me know if there is anything else I need to do. |
|
Looks like it'll need another workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
Update controller-runtime to v0.16.2 and cluster-api to v1.5.2.
closes #1362
Release Note
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits