Improve Searing Totem AI

[ShiyoKozuki]

🍰 Pullrequest

Stop searing totem from being aggressive and pulling monsters not currently aggrod to you or your party

Proof

https://youtu.be/Bf3lbfSsNKs?list=PLdYVrYJB1PTHV-apnXYXkRhCI-oFR6QIc&t=2325

Issues

fixes #2862

How2Test

Summon a searing totem near aggressive enemies that are not currently engaged

[cpevors]

I put this here. The clip is short, so do watch all of it, but if you need to be directed to the salient portion, go to ~0:36. https://www.youtube.com/watch?v=md96s9FDFQ8

This should dispel your belief that Searing Totem doesn't aggro mobs that are otherwise not engaged in combat with you, and hopefully underscores the possibility (at other parts of the video) that some totems may not cause mobs to aggro, and some may, as I indicated in your other Pull Request.

At best, you need to do more thorough research and/or in-game testing on all matters relating to totems, as I don't think you quite understand the intricacies of how they functioned in Vanilla and continue to function in Classic.

[codestothestars]

I put this here. The clip is short, so do watch all of it, but if you need to be directed to the salient portion, go to ~0:36. https://www.youtube.com/watch?v=md96s9FDFQ8

This should dispel your belief that Searing Totem doesn't aggro mobs that are otherwise not engaged in combat with you, and hopefully underscores the possibility (at other parts of the video) that some totems may not cause mobs to aggro, and some may, as I indicated in your other Pull Request.

At best, you need to do more thorough research and/or in-game testing on all matters relating to totems, as I don't think you quite understand the intricacies of how they functioned in Vanilla and continue to function in Classic.

This video isn't sufficient evidence either. It's from 2018 and high resolution so almost definitely from a private server.

edit: not to mention the taskbar is Windows 10 lol

[cpevors]

That's fair. I will hop on my Shaman when I'm home this evening and bandy about for some contemporaneous, deliberate proof. I just think these PRs miss the mark and leave much to be desired, is all.

[ratkosrb]

No clock on minimap. That means 1.12 client.

[ShiyoKozuki]

I'm not sure why it's allowed for people to be so aggressively rude but all it does it make it so people do not want to submit PR's to this project, which is a bad thing.

[ratkosrb]

I didn't see anyone being rude.

[ShiyoKozuki]

In both my PR's, cpevors was aggressively rude,

[ratkosrb]

We have different definitions of what rude is it seems.

[cpevors]

If you feel I was rude, I can apologise. It certainly wasn't my intention to be rude, let alone "aggressively" so.

To that end, I do often find your own tone and delivery to be needlessly snarky and off-putting, so I'd encourage you to not fling stones unless you're above reproach.

[ShiyoKozuki]

Thank you for your apology, it is appreciated.
Were you able to test totems on retail era?

[cpevors]

Thank you for your apology, it is appreciated. Were you able to test totems on retail era?

I got busy with my graduate school studies and admittedly forgot. I'll prioritise it this afternoon, when I'm back behind my home computer. Apologies for a delay.

[ratkosrb]

vid.2025-01-19-0010-41.mp4

Proven to be incorrect on Classic Era PTR.