Creature aggroing totems fix

[ShiyoKozuki]

🍰 Pullrequest

Stops creatures from aggroing totems

Proof

https://youtu.be/Q7XLXSEMGLg?list=PLdYVrYJB1PTHV-apnXYXkRhCI-oFR6QIc&t=2934
https://youtu.be/tDpsIzB__g0?list=PLdYVrYJB1PTHV-apnXYXkRhCI-oFR6QIc&t=1845

Issues

fixes #2863

How2Test

Summon a totem by a mob

[cpevors]

Is your conjecture that totems left in the overworld don't draw aggro when a patrol mob happens upon them? Because if so, that's just not correct, and I don't believe your linked videos prove that point at all.

I can hop on my own Classic Shaman later to prove you wrong, when I'm back home, or you can review this Blizzard forum thread, in which people lament and discuss that Shaman totems very much do pull mobs.

https://us.forums.blizzard.com/en/wow/t/shaman-totems-need-a-fix/1666246/6

Now, it's possible that some totems do not aggro mobs, but even in that case, your fix in this PR is not appropriate.

[ShiyoKozuki]

The shaman was on the opposite side of the totem and the mob aggrod the shaman and NOT the totem, despite the totem being closer to the mob than the shaman.
https://www.youtube.com/watch?list=PLdYVrYJB1PTHV-apnXYXkRhCI-oFR6QIc&t=1845&v=tDpsIzB__g0&feature=youtu.be

On vmangos, mobs aggro to totems from much further than that video
It's basically player aggro range x2 at all times.

I'm fine with someone showing me I'm wrong about this, so please do so.

[cpevors]

If your conjecture is that the aggro range is off, then certainly, that's fair. But your PR doesn't fix the aggro range, it fixes the possibility of totems aggroing mobs altogether, which is not correct behaviour.

If the aggro range is in dispute, it'll need to be looked over in a sniff. It's not possible to simply observe what the range should be from a video, and "basically 2x" isn't exactly something one could take to the bank.