Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of get_observer #939

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Remove uses of get_observer #939

merged 5 commits into from
Jan 29, 2025

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Nov 27, 2024

Purpose

  • Be consistent about how the observer of the quantization arguments is referenced
    From compressed tensors:
def get_observer(self):
    return self.observer

Postrequisites

Changes

  • Remove all uses of quantization_args.get_observer()

Testing

grep -r '\.get_observer()' src examples tests

Signed-off-by: Kyle Sayers <[email protected]>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@horheynm
Copy link
Collaborator

This is all the pathway that uses get_observer?

@kylesayrs
Copy link
Collaborator Author

@horheynm

Testing

grep -r '\.get_observer()' src examples tests

@kylesayrs kylesayrs added the ready When a PR is ready for review label Jan 23, 2025
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rebase/make sure tests pass

@mgoin mgoin merged commit e32c8dc into main Jan 29, 2025
7 checks passed
@mgoin mgoin deleted the kylesayrs/depreciate-get_observer branch January 29, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants