Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] GPTQ Docstring, better argument grouping #841

Closed
wants to merge 8 commits into from

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Oct 11, 2024

Background

#36 Updated the GPTQModifier argument name, but did not change the docstring

Changes

  • Fix targets docstring on GPTQModifier
  • Rearrange modifier arguments for clarity

Testing

  • N/A

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@kylesayrs kylesayrs self-assigned this Oct 13, 2024
@kylesayrs kylesayrs requested a review from rahul-tuli October 18, 2024 14:23
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the targets param not used anywhere? seems like the last PR kept it, on line 101

@kylesayrs
Copy link
Collaborator Author

@dsikka targets is used, but in the sense that it is an argument for QuantizationModifier which piggybacks on GPTQModifier. The docstring only includes GPTQModifier-specific arguments. This "piggybacking" design will be removed in the lifecycle refactor.

@markurtz
Copy link
Collaborator

Why are renaming / standardizing on sequential targets? The original goal, across all modifiers, was to standardize on targets as the base name to represent the scope of which the modifier would target -- I'd prefer not to deviate from that whenever we can.

@kylesayrs
Copy link
Collaborator Author

@markurtz The GPTQModifier has two targets arguments, targets which selects which modules to compress, and sequential_targets, which selects which modules are considered layers (transformer blocks) for the purposes of true_sequential=False. Both are required, since the inferred defaults are not always correct and should be capable of being overridden.

@kylesayrs kylesayrs changed the title Fix GPTQ Docstring, better argument grouping [Docs] GPTQ Docstring, better argument grouping Oct 23, 2024
@kylesayrs kylesayrs requested a review from dsikka November 4, 2024 20:54
@kylesayrs
Copy link
Collaborator Author

Closing for #914

@kylesayrs kylesayrs closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants