-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] GPTQ Docstring, better argument grouping #841
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the targets param not used anywhere? seems like the last PR kept it, on line 101
@dsikka |
Why are renaming / standardizing on sequential targets? The original goal, across all modifiers, was to standardize on targets as the base name to represent the scope of which the modifier would target -- I'd prefer not to deviate from that whenever we can. |
@markurtz The |
Closing for #914 |
Background
#36 Updated the GPTQModifier argument name, but did not change the docstring
Changes
Testing