potential fix to the bug im having #23622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22046 |
|
what? i hate github |
I have reopened it. |
|
Can you please describe in more details what problem this PR solves, and potentially provide a regression test, that fails on master, but passes here? |
enghitalo
reviewed
Feb 1, 2025
| mut status_code := "" | ||
| mut status_msg := "" | ||
| //this may be a hack, but it means i can get free completions from ai.hackclub.com | ||
| //fix sites that send malformed responses with leading newlines |
There was a problem hiding this comment.
Well... I think we must avoid handling things out of documented standards.
There was a problem hiding this comment.
Returning an error would be more interesting to respond to a bad request error. IMHO
|
this was supposed to be a pr on my own repo, this is not at all ready for prod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.