Collection View #126
Merged
Collection View #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Image is now generated and displayed in query term container - A query, once created, can be edited later - Fixed calculation of positions, which now enables full control over position of skeleton as well as individual joints.
…e and copy operation based on this functionality.
*Fixed disable state of joints being ignored *Increased size of joints for easier manipulation *Made radius less scared 😱
…e-query # Conflicts: # openapi/cineast/.openapi-generator/FILES # openapi/cineast/README.md # openapi/cineast/model/mediaObjectDescriptor.ts # openapi/cineast/model/queryConfig.ts # openapi/cineast/model/queryTerm.ts # openapi/cineast/package.json # package-lock.json # package.json # src/app/query/containers/query-container.component.html # src/app/query/containers/query-term.component.html # src/app/query/containers/query-term.module.ts # src/app/shared/model/queries/staged-query-container.model.ts # src/config.json
# Conflicts: # package-lock.json # src/app/shared/model/queries/staged-query-container.model.ts
…ich are not in the default cineast config and unextracted for v3c2
# Conflicts: # openapi/cineast/README.md # openapi/cineast/model/queryConfig.ts # openapi/cineast/model/temporalQuery.ts # openapi/cineast/model/temporalQueryConfig.ts # openapi/cineast/package.json
sauterl
previously approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Looks good to me. It would be beneficial to address my comment, which - to me - is no dealbreaker.
Thanks @silvanheller for your work!
# Conflicts: # openapi/cineast/README.md # openapi/cineast/package.json
sauterl
previously approved these changes
Apr 25, 2022
# Conflicts: # openapi/cineast/.openapi-generator/FILES # openapi/cineast/api/misc.service.ts # openapi/cineast/api/object.service.ts # openapi/cineast/model/queryConfig.ts # openapi/cineast/model/temporalQuery.ts # openapi/cineast/model/temporalQueryConfig.ts # package-lock.json # package.json # src/app/query/containers/query-container.component.html # src/app/shared/model/results/scores/results-container.model.ts # src/config.json
Spiess
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simple view where one can inspect all available multimediaobjects (
/collection):The functionality is very basic:
There are surely some features that would be good to add, but this is basic functionality that we should have probably had since a long time.
This PR needs vitrivr/cineast#288 to work. It also builds upon the pose-query branch, and thus targets it to more easily see the diff.