A PR for migrating Cineast features #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
lucaro
reviewed
Aug 21, 2024
|
|
||
| companion object { | ||
| /** [LinearCorrespondence] for [EHDRetriever]. Maximum distance is taken from Cineast implementation. */ | ||
| private val CORRESPONDENCE = LinearCorrespondence(16 / 4f) |
There was a problem hiding this comment.
^^
As written: It's been taken from the Cineast implementation.
There was a problem hiding this comment.
yeah, but I don't think we need to necessarily backport sins of the past
There was a problem hiding this comment.
I agree.
Frankly, I was assuming there to be some "educational" value in the notation. Sometimes I express thing like this myself to hint at how the value was derived.
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
…s feature modules now return a DenseRetriever instance instead of their own implementation. Signed-off-by: Ralph Gasser <[email protected]>
…r/vitrivr-engine into feature/cineast-migration # Conflicts: # vitrivr-engine-module-features/src/main/kotlin/org/vitrivr/engine/module/features/feature/averagecolor/AverageColorRetriever.kt
…ner and XYZColorContainer. Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
…r-engine into feature/cineast-migration
…her default features. Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
…on it. Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
lucaro
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Cineast features that we have decided to migrate.
See #94 for discussion