bugfix: added content authors to all extractors #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without having reviewed this in detail yet: What I would like to see is a unit test that demonstrates how this mechanism works. I could imagine building a pipeline manually and running an example video clip through it and then having two branches: One dealing with the individual frames and one dealing with an aggregation. |
Signed-off-by: Ralph Gasser <[email protected]>
Signed-off-by: Ralph Gasser <[email protected]>
ppanopticon
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #102 by adding filtering based on content author attributes to all extractors. Obviously, since this is currently only done for content and not for attributes, such extractors as TemporalMetadata or SourceMetadata are not affected. In future a refactoring that handles all of this in a unified way might be beneficial.