Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hooks for Memberships Managers! #31

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

pandres95
Copy link
Member

Last Pull Request of the year ;)

This Pull Request introduces a WithHooks structure to allow memberships managers to have configurable hooks that extend the functionality of them independent of its inherent design.

This would allow, for example, handling memberships based off on non-fungibles to do some logic after a membership is assigned (i.e. copy some attributes to the newly assigned membership), released (i.e. synchronizing gas tank information, if applies), or rank set (i.e. updating polls).

@pandres95 pandres95 requested a review from olanod December 31, 2024 05:52
@pandres95 pandres95 self-assigned this Dec 31, 2024
Copy link
Member

@olanod olanod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work, I like the hooks concept for the memberships.

@olanod olanod merged commit 431cbb4 into main Jan 1, 2025
6 checks passed
@olanod olanod deleted the feat/memberships-with-hooks branch January 1, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants