Adding deprecation flags for SEV components and bumping to 5.1 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGonzalezVillal
requested review from
tylerfanelli and
larrydewey
as code owners
DGonzalezVillal
force-pushed
the
sev-deprecation
branch
from
8170fd6 to
0de11c9
Compare
DGonzalezVillal
changed the title
|
Adding WIP flag, waiting for 5.0 release first |
|
Set to draft PR as well, so this can't be merged. |
As discussed, adding deprecation flags for SEV components, so that it can be removed in the next 6.0 release. Bumping to 5.1 so that people can still use 5.0.0 without compilation warnings if they are using SEV. Signed-off-by: DGonzalezVillal <[email protected]>
DGonzalezVillal
force-pushed
the
sev-deprecation
branch
from
0de11c9 to
438a9fc
Compare
DGonzalezVillal
changed the title
|
Can be merged now if we want this still |
tylerfanelli
requested changes
Dec 17, 2024
| @@ -4,9 +4,24 @@ | |||
| //! | |||
| //! These are primarily offered as a convenience measure to avoid making | |||
| //! HTTP requests to AMD's servers. | |||
|
|
|||
There was a problem hiding this comment.
You left a deprecated note on this module in src/certs/mod.rs. Why are these deprecation notes also needed?
larrydewey
approved these changes
Jan 6, 2025
|
Let's hold off on this until sev-5.0.0 is packaged for distros. Will revisit this at that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, adding deprecation flags for SEV components, so that it can be removed in the next 6.0 release. Bumping to 5.1 so that people can still use 5.0.0 without compilation warnings if they are using SEV.