Top banner #42
Open
Top banner #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmay3011
reviewed
Aug 8, 2018
| @@ -0,0 +1,5 @@ | |||
| class AddMobileBannerToSpreeBanners < ActiveRecord::Migration[5.1] | |||
| def change | |||
| add_column :spree_banners, :mobile_banner, :boolean, default: false | |||
| def change | ||
| create_table :spree_banners do |t| | ||
| t.string :title | ||
| t.boolean :active, default: false |
| @@ -0,0 +1,10 @@ | |||
| <% banners = (request.variant.include?(:phone)) ? Spree::Banner.mobile_banner : Spree::Banner.active %> | |||
There was a problem hiding this comment.
Cache this partial. Avoid firing query from views.
himanshumishra31
force-pushed
the
top-banner
branch
from
f6c5e6f to
45a1e70
Compare
himanshumishra31
force-pushed
the
top-banner
branch
from
45a1e70 to
e99ba32
Compare
himanshumishra31
force-pushed
the
top-banner
branch
from
a08a00a to
6a9dc05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.