Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light and Dark mode added #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Light and Dark mode added #82

wants to merge 1 commit into from

Conversation

karnikagupta30
Copy link

Description

  • ...Light mode button is added.
  • ...By clicking on the icon in the header, dark mode can be switched to light mode and vice-versa.

Related issue(s)
Resolves #69

@vinayakgavariya
Copy link
Owner

Hey @tokyo3001 can you send a video or gif for the same ?

@karnikagupta30
Copy link
Author

WhatsApp.Video.2022-10-08.at.12.32.20.AM.mp4

@vinayakgavariya
Copy link
Owner

Is it working fine for different size screens too?
Is the responsiveness working fine?

Will be glad to merge your pr.

@karnikagupta30
Copy link
Author

Is it working fine for different size screens too? Is the responsiveness working fine?

Will be glad to merge your pr.

@VG-1 It is working fine for different screen sizes and responsiveness is also fine.

vinayakgavariya
vinayakgavariya approved these changes Oct 8, 2022
View reviewed changes
Copy link
Owner

@vinayakgavariya vinayakgavariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @tokyo3001 .
It will be great if you can send a video for the responsiveness too.
Inspect and try to change the screen sizes there.
Will be happy to merge your PR.

@karnikagupta30
Copy link
Author

Great @tokyo3001 . It will be great if you can send a video for the responsiveness too. Inspect and try to change the screen sizes there. Will be happy to merge your PR.

WhatsApp.Video.2022-10-08.at.5.47.33.PM.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinayakgavariya vinayakgavariya vinayakgavariya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light and Dark mode button
2 participants
@karnikagupta30 @vinayakgavariya