Danebook #35
Open
Danebook #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comment test |
|
Woooo, comments!!! Yeah |
|
When I logout and then go to the timeline page, I get an error |
| get 'comments/new' | ||
|
|
||
| resources :users do | ||
| resource :profiles |
There was a problem hiding this comment.
use shallow: true if you can
should resource be resources?
|
when i try to go to a page that doesnt have a user, i get redirected to the home page which is nice, but then i dont have a way to get back to the timeline |
|
the search button breaks the app (as exepected because we haven't done that yet!) |
| def destroy | ||
| @post = Post.find_by_id(params[:id]) | ||
| @post.destroy | ||
| redirect_to current_user |
There was a problem hiding this comment.
probably makes more sense to redirect to the profile you are currently on, not your own profile
| resources :users do | ||
| resource :profiles, only: [:edit, :show, :update] | ||
| resources :posts, only: [:create, :destroy] | ||
| resources :photos |
There was a problem hiding this comment.
You can make this a shallow route, for both posts and photos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.