Disabling calendar auto-open on load #489
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hasty bugfix for those experiencing #488 , and a quality-of-life improvement (in my opinion).
It seems setting the default value of 'openOnLoad' to false did not solve the bug. The setting still reverts to 'true' on every new session of play. I am at a loss as to why. As such, I disabled the auto-opening of the calendar at load directly until a more permanent solution can be found.
Besides the bug I find it in my taste that the 'openOnLoad' should be set to false as a default for all users. Especially new users of Foundry can be overwhelmed with popups and not be sure how to disable the setting. As such, it falls to the GM to guide the player through the configuration process. Yes, it can be a two-click process right now, but in my experience the conversation tends to go something like this:
Player: "Why does the calendar pop open every time we play?"
GM: "You can turn that off in the settings menu of the calendar."
Player: "Oh, where was that? I just closed the calendar."
GM: "It's in the Journal Notes tab, then click Simple Calendar."
Player: "Journal Notes tab?"
GM: "It's the banner looking button on the left of the screen. Click that."
Player: "I see it. Ah there, I have it open now."
GM: "Now click the cogwheel button and then set Open On Load to off. It's in the upper part of the settings that will appear."
Player: "Ah, got it! But now I can't select any tokens?"
GM: "Now you should turn Token Controls back on. It's the uhh... person looking icon near the top left. Like above where the Journal Notes button is. The top left one."
Player: "Got it, thanks!"
Player 2: "Wait GM, can you guide me through that process too? I wasn't paying attention."
GM: dies