Feature/agent track layout #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically a step in the right direction, but it breaks track group layout and none of the spacing is right. I'm gonna want to find some tool for detecting unused CSS rules when I'm done here, this is all very messy.
There are still a lot of problems. There's a layering issue that makes the admin buttons unusable, for instance.
This seems important since they're left-aligned now. It's still possible for them to extend beyond the edge of the screen, though, and they're still dogshit on mobile, so maybe some more thought is needed.
I am not sure what changed to break this.
I tried to calibrate the change such that metadata wraps at about the same point as it currently does on the production site.
This doesn't change much visually, yet, but it sets us up for the stuff me and @theshillito talked about this morning.
The expansion doesn't actually look like anything at the moment.
It's something pretty ugly, but it is at least something.
The ordering is very wrong, though. Perhaps we should be using css grids or something.
It's pretty ugly though.
We're already using it on the browse page, so this makes sense.
There were some problems with this, and we're planning to do a proper job of this in `main` soon anyway.
colons
force-pushed
the
feature/agent-track-layout
branch
from
a013929 to
35e8afd
Compare
colons
force-pushed
the
feature/agent-track-layout
branch
from
8aff6b7 to
b15a754
Compare
This place has Some Problems, but I think this basic idea makes more sense than where it was.
Fail for narrow browser widths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// pitch tbd