Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view definition capture in DataHub for Vertica schemas with uppercase letters #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohansun
Copy link

@rohansun rohansun commented Oct 4, 2024

This PR fixes a bug where view definitions were not captured in DataHub when Vertica schema names contained uppercase letters. The table_schema column in V_CATALOG.VIEWS displays schema names exactly as they were created. For example, if a schema was created as CREATE SCHEMA myschema1;, it would be displayed as myschema1, while CREATE SCHEMA mySchema2; would be displayed as mySchema2, preserving the original casing.

The current code compares table_schema using table_schema = lower(any_schema_in_the_database), which causes issues with schema names that have uppercase letters.

This fix updates the query to use lower(table_schema) = lower(any_schema_in_the_database), allowing DataHub to capture view definitions for schemas regardless of whether their names contain uppercase characters.

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants