add setup-prometheus-adapter #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qindotguan
requested review from
roypaulin,
cchen-vertica,
fenic-fawkes,
HaoYang0000 and
LiboYu2
as code owners
roypaulin
reviewed
Dec 26, 2024
Makefile
Outdated
| setup-prometheus-adapter: ## Setup prometheus adapter for VerticaAutoscaler | ||
| helm repo add prometheus-community https://prometheus-community.github.io/helm-charts | ||
| helm repo update | ||
| helm install prometheus-adapter prometheus-community/prometheus-adapter --namespace monitoring --create-namespace |
There was a problem hiding this comment.
Make the release name and namespace a parameter. Default release name and namespace can be prometheus-adapter.
- There must be an undeploy command too
- The user must be able to set the prometheus url, prometheus port , the number of replicas.
There was a problem hiding this comment.
- add PROMETHEUS_ADAPTER_NAME and PROMETHEUS_ADAPTER_NAMESPACE
- added undeploy-prometheus-adapter
- added example values with
--set prometheus.url,--set prometheus.port, and--set replicas. I will make them configurable later
roypaulin
reviewed
Dec 26, 2024
Co-authored-by: Roy Paulin <[email protected]>
roypaulin
reviewed
Jan 6, 2025
Makefile
Outdated
| PROMETHEUS_ADAPTER_NAMESPACE ?= prometheus-adapter | ||
| PROMETHEUS_ADAPTER_REPLICAS ?= 1 | ||
| # The Prometheus service URL and port for Prometheus adapter to connect to | ||
| PROMETHEUS_URL ?= http://prometheus.default.svc |
There was a problem hiding this comment.
Suggested change
| PROMETHEUS_URL ?= http://prometheus.default.svc | |
| PROMETHEUS_URL ?= http://$(PROMETHEUS_HELM_NAME)-kube-prometheus-prometheus.$(PROMETHEUS_NAMESPACE).svc |
Also move the adapter variables ddfinition after prometheus'
Makefile
Outdated
| deploy-prometheus-adapter: ## Setup prometheus adapter for VerticaAutoscaler | ||
| helm repo add prometheus-community https://prometheus-community.github.io/helm-charts | ||
| helm repo update | ||
| helm install $(DEPLOY_WAIT) -n ${PROMETHEUS_ADAPTER_NAMESPACE} --create-namespace ${PROMETHEUS_ADAPTER_NAME} prometheus-community/prometheus-adapter --values prometheus/adapter.yaml --set prometheus.url=${PROMETHEUS_URL} --set prometheus.port=${PROMETHEUS_PORT} --set replicas=${PROMETHEUS_ADAPTER_REPLICAS} |
There was a problem hiding this comment.
Suggested change
| helm install $(DEPLOY_WAIT) -n ${PROMETHEUS_ADAPTER_NAMESPACE} --create-namespace ${PROMETHEUS_ADAPTER_NAME} prometheus-community/prometheus-adapter --values prometheus/adapter.yaml --set prometheus.url=${PROMETHEUS_URL} --set prometheus.port=${PROMETHEUS_PORT} --set replicas=${PROMETHEUS_ADAPTER_REPLICAS} | |
| helm install $(DEPLOY_WAIT) -n ${PROMETHEUS_ADAPTER_NAMESPACE} --create-namespace ${PROMETHEUS_ADAPTER_NAME} prometheus-community/prometheus-adapter --values prometheus/adapter.yaml --set prometheus.url=${PROMETHEUS_URL} --set prometheus.port=${PROMETHEUS_PORT} --set replicas=${PROMETHEUS_ADAPTER_REPLICAS} $(PROMETHEUS_ADAPTER_HELM_OVERRIDES) |
Add PROMETHEUS_ADAPTER_HELM_OVERRIDES that we can use to set more fields.
prometheus/adapter.yaml
Outdated
Comment on lines
2
to
8
| prometheus: | ||
| url: http://prometheus.default.svc | ||
| port: 9090 | ||
| path: "" | ||
|
|
||
| # Number of prometheus adapter instances | ||
| replicas: 1 |
There was a problem hiding this comment.
Suggested change
| prometheus: | |
| url: http://prometheus.default.svc | |
| port: 9090 | |
| path: "" | |
| # Number of prometheus adapter instances | |
| replicas: 1 |
This is not needed. The default replica is already 1
|
@roypaulin If a vdb has sandboxes, how do we exclude them when collecting metrics? |
It can be done on prometheus by setting the service monitor to target only specific subclusters, but We do not need to exclude them, the hpa will select only subclusters that match the service name specified in the CR. |
roypaulin
reviewed
Jan 8, 2025
Makefile
Outdated
Comment on lines
162
to
165
| DB_USER?=dbadmin | ||
| DB_PASSWORD?= | ||
| VDB_NAME?=verticadb-sample | ||
| VDB_NAMESPACE?=default |
There was a problem hiding this comment.
Move these next to other prometheus variables.
|
Try prometheus-sanity first on your local machine to make sure it works. |
roypaulin
approved these changes
Jan 9, 2025
Makefile
Outdated
Comment on lines
162
to
165
| DB_USER?=dbadmin | ||
| DB_PASSWORD?= | ||
| VDB_NAME?=verticadb-sample | ||
| VDB_NAMESPACE?=default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To scale up/down the Vertica DB subcluster size based on prometheus metrics, we need to install the prometheus adapter. This PR provided a way to deploy the promutheus adapter in our e2e test environment.