Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx Docstring for Preprocessing #795

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Sphinx Docstring for Preprocessing #795

merged 7 commits into from
Oct 31, 2023

Conversation

mail4umar
Copy link
Collaborator

  • Scaler
  • StandardScaler
  • RobustScaler
  • MinMaxScaler
  • Balance

@mail4umar mail4umar added the Documentation Documentation issue or requirement. label Oct 31, 2023
@mail4umar mail4umar requested a review from oualib October 31, 2023 04:59
@mail4umar mail4umar self-assigned this Oct 31, 2023
oualib
oualib requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes to make.

verticapy/machine_learning/vertica/preprocessing.py Show resolved Hide resolved
verticapy/machine_learning/vertica/preprocessing.py Outdated Show resolved Hide resolved
verticapy/machine_learning/vertica/preprocessing.py Outdated

.. math::

(x - avg) / std
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should write Z_score = ...

verticapy/machine_learning/vertica/preprocessing.py Outdated

.. math::

(x - median) / (1.4826 * mad)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same Z_rscore

verticapy/machine_learning/vertica/preprocessing.py Outdated

.. math::

(x - min) / (max - min)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same Z_minmax

@oualib oualib merged commit a3fb091 into master Oct 31, 2023
6 of 8 checks passed
@mail4umar mail4umar deleted the sphinx-ml-vertica-preprocessing-2 branch November 21, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oualib oualib oualib approved these changes

Assignees

@mail4umar mail4umar

Labels
Documentation Documentation issue or requirement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mail4umar @oualib