Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstring changes for memmodel/decomposition #777

Merged

Conversation

abhsharma2
Copy link
Collaborator

No description provided.

@oualib oualib requested review from mail4umar and oualib October 26, 2023 23:15
to check the attributes of the rotated model

.. ipython:: python
:suppress:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only question is: why using :suppress: everywhere? Will it not delete the entire cell?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mail4umar any idea?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I directly rendered it and it looks fine.

This is because the indentation of the suppress is wrong. So I think @abhsharma2 should remove it from everywhere.

Import the required module.

.. ipython:: python
:suppress:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary suppress from entire doc.

@mail4umar mail4umar self-requested a review October 27, 2023 11:49
@oualib oualib merged commit b592d53 into vertica:master Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants