Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

746 tests vdataframe math and rolling #776

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

vikash018
Copy link
Collaborator

UT code for math and rolling functions.

Two observations:

  1. log function in apply_fun - Expected log arg from vertica doc is log (base, expression). However, Verticapy is considering log (expression, base) i.e. in reverse order.

titanic["age"].apply_fun(func = "log")

  1. mad (median absolute deviation) function in analytic is using mean instead of median.
    titanic.analytic(func="mad", columns="age", name="mad")

@vikash018 vikash018 linked an issue Oct 25, 2023 that may be closed by this pull request
@vikash018 vikash018 added Unit Testing The selected function/method needs the implementation of UT. Core - vDataFrame Anything related to the vDataFrame object. labels Oct 25, 2023
@vikash018 vikash018 requested review from oualib and mail4umar October 25, 2023 19:45
@oualib
Copy link
Member

oualib commented Oct 31, 2023

Creating another PR to solve the two issues.

@oualib oualib merged commit 7ba6a89 into master Oct 31, 2023
7 checks passed
@mail4umar mail4umar deleted the 746-tests-vdataframe-math-and-rolling branch September 24, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core - vDataFrame Anything related to the vDataFrame object. Unit Testing The selected function/method needs the implementation of UT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: vDataFrame - math + rolling
3 participants