-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx Docstring Update for MachineLearning/Vertica/LinearModel #753
Conversation
Draft for LinearRegression. Rest of the ml algortihm classes will follow the same syntax.
Fixing the example. @mail4umar: TODO - Verify each reference, for some them the link needs to be added. Please double check the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes to make.
The following examples provide a basic understanding of usage. For more | ||
detailed examples, please refer to the User Guide or the "Examples" | ||
The following examples provide a basic understanding of usage. For more | ||
detailed examples, please refer to the :ref:`user_guide.machine_learning` or the "Examples" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add link to the example page of the VerticaPy Website.
By assigning an alias to ``verticapy``, we mitigate the risk of code | ||
collisions with other libraries. This precaution is necessary | ||
because verticapy uses commonly known function names like "average" | ||
and "median," which can potentially lead to naming conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma inside '"' move it out.
The following examples provide a basic understanding of usage. For more | ||
detailed examples, please refer to the User Guide or the "Examples" | ||
The following examples provide a basic understanding of usage. For more | ||
detailed examples, please refer to the :ref:`user_guide.machine_learning` or the "Examples" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also PEP, try to go back to the next line after the ref.
use them effectively. These datasets are invaluable resources for honing your | ||
VerticaPy offers a wide range of sample datasets that are ideal for training | ||
and testing purposes. You can explore the full list of available datasets in | ||
the :ref:`api.datasets`, which provides detailed information on each dataset and how to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP go back to line after dataset.
In this case, VerticaPy utilizes seeded randomization to guarantee the | ||
reproducibility of your data split. However, please be aware that this | ||
approach may lead to reduced performance. For a more efficient data | ||
split, you can use the :py:mod:`vDataFrame.to_db` method to save your results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
@@ -650,19 +650,19 @@ class LinearRegression(Regressor, LinearModel): | |||
|
|||
vp.set_option("plotting_lib", "plotly") | |||
fig = model.features_importance() | |||
fig.write_html("SPHINX_DIRECTORY/figures/machine_learning_vertica_linear_model_lr_feature.html") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing SPHINX directory.
Draft for LinearRegression. Rest of the ml algorithm classes will follow the same syntax.
@oualib can you please check.