Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalising corr's docstring #751

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Finalising corr's docstring #751

merged 3 commits into from
Oct 18, 2023

Conversation

oualib
Copy link
Member

@oualib oualib commented Oct 17, 2023

  • finalising the corr docstring file.

@mail4umar

Please check if everything is working well. I tried to use the HTML file of datasets to represent titanic and amazon and I am not sure it will work.

Besides, should we seed the randomness for the examples? So users can reproduce the example?

Please review ASAP so I can use this methodology on new files.

@oualib oualib requested review from tconsigny and mail4umar October 17, 2023 20:57
@oualib oualib added the Documentation Documentation issue or requirement. label Oct 17, 2023
@mail4umar
Copy link
Collaborator

@oualib That was a great idea to avoid having too many tables. I have fixed black. It should be all good now.

@oualib oualib merged commit a414414 into master Oct 18, 2023
7 checks passed
@mail4umar mail4umar deleted the sphinx-conversion-corr-part2 branch November 21, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation issue or requirement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants