Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified doc string of memmodel/linear_model.py #747

Merged
merged 5 commits into from
Oct 17, 2023
Merged

modified doc string of memmodel/linear_model.py #747

merged 5 commits into from
Oct 17, 2023

Conversation

abhsharma2
Copy link
Collaborator

Changed docstrings of memmodel/linear_model.py to include code examples

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

oualib
oualib requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • add more example (separated by section)
  • format properly your code
  • use multiple blocks
  • add more notes and hints

verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Show resolved Hide resolved
oualib
oualib requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some corrections to make

verticapy/machine_learning/memmodel/linear_model.py Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Show resolved Hide resolved
verticapy/machine_learning/memmodel/linear_model.py Outdated Show resolved Hide resolved
@oualib
Copy link
Member

oualib commented Oct 13, 2023

@mail4umar as all these objects are classes, do you have any best practices to display them nicely?

oualib
oualib approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@oualib oualib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for Umar's approval before merging.

@mail4umar
Copy link
Collaborator

@abhsharma2 you can update the changes and then run the checks.

@oualib oualib merged commit 574bfae into vertica:master Oct 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mail4umar mail4umar mail4umar requested changes

@oualib oualib oualib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhsharma2 @CLAassistant @oualib @mail4umar