uncommented math issue and increase tolerance for classification_metr…

…ics (#826)
vertica · Nov 3, 2023 · 797a8d9 · 797a8d9
1 parent 9f6252d
commit 797a8d9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/verticapy/tests_new/core/vdataframe/test_math.py b/verticapy/tests_new/core/vdataframe/test_math.py
@@ -199,12 +199,12 @@ def test_apply(self, titanic_vd_fun, columns, input_type, func, copy_name):
             ("album_cost", "sample_data", "len", "np.size(x)"),
             ("album_cost", "sample_data", "length", "np.size(x)"),
             ("age", None, "ln", "np.log(x)"),
-            # (
-            #     "fare",
-            #     None,
-            #     "log",
-            #     "np.log2(x, where=x != 0)",
-            # ),  # Looks like bug in code. Expected log arg from vertica doc is log(base, expression). However, Verticapy is considering log(expression, base) i.e. in reverse order.
+            (
+                "age",
+                None,
+                "log",
+                "np.log2(x, where=x != 0)",
+            ),
             ("age", None, "log10", "np.log10(x)"),
             ("album_cost", "sample_data", "max", "np.max(x)"),
             ("album_cost", "sample_data", "min", "np.min(x)"),
@@ -516,18 +516,18 @@ def test_slice(self, smart_meters_vd, length, unit, start, column, expected):
                 REL_TOLERANCE,
                 ABS_TOLERANCE,
             ),
-            # (
-            #     "mad",
-            #     "age",
-            #     None,
-            #     None,
-            #     "new_colm",
-            #     1,
-            #     0.5,
-            #     True,
-            #     REL_TOLERANCE,
-            #     ABS_TOLERANCE,
-            # ),  # Fail. looks like bug in code. vpy code has mean instead of median.
+            (
+                "mad",
+                "age",
+                None,
+                None,
+                "new_colm",
+                1,
+                0.5,
+                True,
+                REL_TOLERANCE,
+                ABS_TOLERANCE,
+            ),
             (
                 "max",
                 "age",

diff --git a/verticapy/tests_new/machine_learning/metrics/test_classification_metrics.py b/verticapy/tests_new/machine_learning/metrics/test_classification_metrics.py
@@ -280,7 +280,7 @@ def test_master_classification_metrics(
         global python_metrics_map
         python_metrics_map = defaultdict(list)
         func_args = {}
-        rel_tolerance = 1e-4
+        rel_tolerance = 1e-2
 
         (
             vdf,
@@ -311,7 +311,7 @@ def test_master_classification_metrics(
         elif metric_name in ["prc_auc_score"] and compute_method in [
             "macro",
         ]:
-            pytest.skip("Need to fix it")
+            pytest.skip("vertica binning issue needs to be fixed.")
         elif metric_name in ["log_loss"]:
             pytest.skip("vertica has default base 10, sklean uses natural log (e)")