Skip to content

Commit

Permalink
More PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
NicholasLYang committed Jan 3, 2025
1 parent 93929ce commit f88ac08
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 2 additions & 3 deletions crates/turborepo-lib/src/boundaries.rs
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ impl Run {
// We assume the tsconfig.json is at the root of the package
let tsconfig_path = package_root.join_component("tsconfig.json");

// TODO: Load tsconfig.json
let resolver =
Tracer::create_resolver(tsconfig_path.exists().then(|| tsconfig_path.as_ref()));

Expand Down Expand Up @@ -296,9 +295,9 @@ impl Run {
}
// We use `relation_to_path` and not `contains` because `contains`
// panics on invalid paths with too many `..` components
if matches!(
if !matches!(
package_path.relation_to_path(&resolved_import_path),
PathRelation::Divergent | PathRelation::Child
PathRelation::Parent
) {
Ok(Some(BoundariesDiagnostic::ImportLeavesPackage {
import: import.to_string(),
Expand Down
5 changes: 1 addition & 4 deletions crates/turborepo-lib/src/query/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@

mod external_package;
mod boundaries;
mod external_package;
mod file;
mod package;
mod server;
Expand All @@ -15,7 +14,6 @@ use std::{
use async_graphql::{http::GraphiQLSource, *};
use axum::{response, response::IntoResponse};
use external_package::ExternalPackage;
use miette::Diagnostic;
use package::Package;
pub use server::run_server;
use thiserror::Error;
Expand Down Expand Up @@ -153,7 +151,6 @@ impl RepositoryQuery {
#[graphql(concrete(name = "Packages", params(Package)))]
#[graphql(concrete(name = "ChangedPackages", params(ChangedPackage)))]
#[graphql(concrete(name = "Files", params(File)))]
#[graphql(concrete(name = "TraceErrors", params(file::TraceError)))]
#[graphql(concrete(name = "ExternalPackages", params(ExternalPackage)))]
#[graphql(concrete(name = "Diagnostics", params(Diagnostic)))]
pub struct Array<T: OutputType> {
Expand Down

0 comments on commit f88ac08

Please sign in to comment.