-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solidity test - with signature test - working #59
Conversation
Delegate and Attribute complete closes veramolabs#56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still reviewing. It's a massive change so it will take a while longer :/
I decided to share some of my notes as I might be misunderstanding some things (I haven't used foundry before).
packages/did-eth-registry/test/EthereumDIDRegistryAttribute.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
packages/did-eth-registry/test/EthereumDIDRegistryDelegate.t.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I think it's a solid foundation to build further features.
Delegate and Attribute complete
closes #56
This PR introduces comprehensive testing in Solidity for the
did-eth-registry
. By consolidating our tests within a single high-performance Solidity framework, we simplify future improvements and refactoring efforts. This approach also eliminates the need to switch between different language implementations, streamlining our development process.