Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ci(typing): Disable
mypy
code [annotation-unchecked]
on examples
Disables the non-blocking warning that appeared since (1d01fa0) https://github.com/vega/altair/actions/runs/12843721674/job/35815966648?pr=3747#step:8:13 > tests\examples_methods_syntax\deviation_ellipses.py:56: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] > tests\examples_arguments_syntax\deviation_ellipses.py:56: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] I don't consider this useful because: 1. The signature annotations were removed deliberately. Prior to this, they already did the dance of making the stubs of `pandas`, `numpy` and `scipy` happy. 2. The default of `mypy` is the opposite of ((`pyright`|`pylance`))[https://microsoft.github.io/pyright/#/mypy-comparison?id=type-checking-unannotated-code]. I'm not planning to enable `--check-untyped-defs` - but I do want to avoid having warnings in VSCode. 3. Annotations within examples are helpful for getting the correct completions, in cases where inference fails. This is why `pd.Series[float]` was added - to resolve `pandas` complex indexing `@overload`(s)
- Loading branch information