Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devcontainer.json #95

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Create devcontainer.json #95

merged 7 commits into from
Nov 20, 2023

Conversation

niemasd
Copy link
Collaborator

@niemasd niemasd commented Nov 11, 2023

With this devcontainer file, VS Code (and GitHub Codespaces) will be able to create the development environment automatically.

@niemasd
Copy link
Collaborator Author

niemasd commented Nov 13, 2023

@stevenweaver This one has now been ported to Oracle Linux and has been tested. I'm able to successfully compile and run HIV-TRACE from the Docker environment via python3 setup.py develop.

Note that this Dockerfile has the tn93 patch regarding OpenMP compatibility. I've documented it in the Dockerfile, and we should delete it once the tn93 code is patched

@stevenweaver
Copy link
Member

@niemasd -- Is it OK to remove the sed commands now?

@niemasd
Copy link
Collaborator Author

niemasd commented Nov 20, 2023

I hadn't heard back re: this question yet:

veg/tn93#34 (comment)

So I'll go ahead and assume option 2 (using the GCC version update you suggested). So I'll do the following:

  1. Update the tn93 Dockerfile to use the updated GCC version fix you found and create a new PR
  2. Update the other repos' Dockerfiles to incorporate this fix as well
  • I'll comment on those repos' PRs to let you know when I've tested them and confirmed that the Dockerfile works successfully

@stevenweaver
Copy link
Member

Thanks Niema, I missed that question.

@niemasd
Copy link
Collaborator Author

niemasd commented Nov 20, 2023

No worries 😄

@niemasd
Copy link
Collaborator Author

niemasd commented Nov 20, 2023

@stevenweaver This PR is ready as of the following commit:

https://github.com/niemasd/hivtrace/commit/a12422f4601f91fd5ba19c13c1fb8e7ffe8a1823

The above commit fixes the Dockerfile such that the tn93 compilation fix for the CMake GCC-10 issue we discussed is incorporated.

@stevenweaver stevenweaver merged commit 7829f33 into veg:master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants