Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support timestamp comparison #580

Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: support timestamp comparison #580

merged 1 commit into from
Nov 30, 2023

Conversation

maksimtor
Copy link
Contributor

Support timestamp comparison using operators <, <=, >, >=.

@bruceg bruceg requested a review from a team November 27, 2023 18:54
@bruceg bruceg added the type: enhancement A value-adding code change that enhances its existing functionality label Nov 27, 2023
@bruceg
Copy link
Member

bruceg commented Nov 28, 2023

Closes #579

@bruceg bruceg linked an issue Nov 28, 2023 that may be closed by this pull request
Using comparison operators with timestamps #579
Closed
@jszwedko
Copy link
Member

Closes #78

@jszwedko jszwedko requested a review from pront November 28, 2023 19:36
@maksimtor maksimtor force-pushed the timestamp-comparison branch 2 times, most recently from 17a9fd8 to 5d5460f Compare November 29, 2023 07:09
@pront pront self-assigned this Nov 29, 2023
pront
pront reviewed Nov 29, 2023
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maksimtor for this PR!

CHANGELOG.md Show resolved Hide resolved
lib/tests/tests/expressions/comparison/ge.vrl Show resolved Hide resolved
@maksimtor maksimtor force-pushed the timestamp-comparison branch from 5d5460f to a385ef4 Compare November 30, 2023 07:45
pront
pront approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pront pront added this pull request to the merge queue Nov 30, 2023
Merged via the queue into vectordotdev:main with commit 3c50a4a Nov 30, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

Assignees

@pront pront

Labels
type: enhancement A value-adding code change that enhances its existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using comparison operators with timestamps
4 participants
@maksimtor @bruceg @jszwedko @pront