performance(stdlib,value): Faster JSON parsing #1249
+40
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubOnderka
force-pushed
the
json-parse-optimisation
branch
3 times, most recently
from
0699755 to
c818790
Compare
JakubOnderka
force-pushed
the
json-parse-optimisation
branch
from
c818790 to
155d8b0
Compare
JakubOnderka
changed the title
pront
changed the title
pront
reviewed
Feb 3, 2025
There was a problem hiding this comment.
This looks great @JakubOnderka. Some CI checks are failing, you can iterate locally with ./scripts/checks.sh. And we will also need a changelog fragment.
pront
reviewed
Feb 3, 2025
| /// Converts a slice of bytes to a string, including invalid characters. | ||
| #[must_use] | ||
| pub fn simdutf_bytes_utf8_lossy(v: &[u8]) -> Cow<'_, str> { | ||
| simdutf8::basic::from_utf8(v).map_or_else( |
There was a problem hiding this comment.
One question that just came up, did you consider encoding_rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge requests speeds up JSON parsing when
lossyis set to true:Change Type
Is this a breaking change?
How did you test this PR?
Standard tests
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.