Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stdlib)!: remove deprecated ellipsis argument from truncate #1188

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

pront
Copy link
Member

@pront pront commented Dec 12, 2024

Summary

ellipsis has been deprecated for a long time.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

@pront
Copy link
Member Author

pront commented Dec 12, 2024

Prepped this PR an exercise for deprecations:

  • Do we need to mark this as breaking?
  • Do we need changelog?

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be marked as a breaking change and a changelog entry included?

@pront pront requested a review from jszwedko January 22, 2025 19:40
@jszwedko jszwedko changed the title chore(stdlib): remove deprecated ellipsis argument from truncate chore(stdlib)!: remove deprecated ellipsis argument from truncate Jan 22, 2025
@jszwedko
Copy link
Member

Prepped this PR an exercise for deprecations:

  • Do we need to mark this as breaking?
  • Do we need changelog?

I'd say yes to both 😄 I updated the PR title to indicate it is breaking too.

@pront pront added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ae472dd Jan 22, 2025
15 checks passed
@pront pront deleted the pront/remove-deprecated-argument branch January 22, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants