review point:

vectordotdev · Jan 29, 2025 · cb2a420 · cb2a420
1 parent 4d23a53
commit cb2a420
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/stdlib/downcase.rs b/src/stdlib/downcase.rs
@@ -1,5 +1,9 @@
 use crate::compiler::prelude::*;
 
+fn downcase(value: &Value) -> Resolved {
+    Ok(value.try_bytes_utf8_lossy()?.to_lowercase().into())
+}
+
 #[derive(Clone, Copy, Debug)]
 pub struct Downcase;
 
@@ -44,7 +48,7 @@ struct DowncaseFn {
 impl FunctionExpression for DowncaseFn {
     fn resolve(&self, ctx: &mut Context) -> Resolved {
         let value = self.value.resolve(ctx)?;
-        Ok(value.try_bytes_utf8_lossy()?.to_lowercase().into())
+        downcase(&value)
     }
 
     fn type_def(&self, _: &state::TypeState) -> TypeDef {

diff --git a/src/stdlib/upcase.rs b/src/stdlib/upcase.rs
@@ -1,5 +1,9 @@
 use crate::compiler::prelude::*;
 
+fn upcase(value: &Value) -> Resolved {
+    Ok(value.try_bytes_utf8_lossy()?.to_uppercase().into())
+}
+
 #[derive(Clone, Copy, Debug)]
 pub struct Upcase;
 
@@ -44,7 +48,7 @@ struct UpcaseFn {
 impl FunctionExpression for UpcaseFn {
     fn resolve(&self, ctx: &mut Context) -> Resolved {
         let value = self.value.resolve(ctx)?;
-        Ok(value.try_bytes_utf8_lossy()?.to_uppercase().into())
+        upcase(&value)
     }
 
     fn type_def(&self, _: &TypeState) -> TypeDef {