Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a working example of vector internal metrics monitoring #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdrouet
Copy link
Contributor

@jdrouet jdrouet commented Nov 23, 2021

This PR follows a question asked on discord.

Signed-off-by: Jérémie Drouet [email protected]

@jdrouet jdrouet force-pushed the vector-internal-monitoring branch from 11841bc to 99c1345 Compare November 23, 2021 08:59
@jdrouet jdrouet marked this pull request as ready for review November 23, 2021 09:06
@jdrouet jdrouet requested a review from lucperkins November 23, 2021 09:06
@lucperkins
Copy link
Contributor

lucperkins commented Nov 30, 2021

I'd recommend adding something to the docs that lets a user explore the produced metrics. Perhaps you could link to something like this URL, which displays a graph for the vector_events_in_total{component_name="blackhole"} metric across a 5-minute time range:

http://localhost:9090/graph?g0.expr=vector_events_in_total%7Bcomponent_name%3D%22blackhole%22%7D&g0.tab=0&g0.range_input=5m

volumes:
- ./prometheus/prometheus.yml:/opt/bitnami/prometheus/conf/prometheus.yml:ro

networks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't blocking, but in general I feel like we should keep the Docker Compose configurations as simple as possible. In this case, Compose automatically creates a default network, which makes an explicit network like this unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants